Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TMTV-colourmap): Fix fail colourmap change on non-HP PTs by changing getMatchingPTDisplaySet function in TMTV mode to get PT from viewer layout rather than hanging protocol match #4007

Closed

Conversation

dxlin
Copy link
Contributor

@dxlin dxlin commented Mar 27, 2024

Context

When PT image is changed in TMTV mode to one different from matched via hanging protocol, colour map breaks.

  1. Load TMTV with multiple PT images
  2. Change colourmap (works)
  3. Load PT image that was not picked by hanging protocol
  4. Change colourmap (fails)

Caused by getMatchingPTDisplaySet, which gets the ptDisplaySet from the hangingprotocol match rather than viewer layout.

Implemented one portion of Todo (getting PT from viewer layout), but attenuation corrected PT vs non-attenuation correct PT remains.

Changes & Results

tmtv\commandsModule.js\getMatchingPTDisplaySet
-change ptDisplaySet to return PT from viewer layout rather than hanging protocol

Testing

  1. Load TMTV with multiple PT images
  2. Change colourmap (works)
  3. Load PT image that was not picked by hanging protocol
  4. Change colourmap (works)

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit b888718
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/660431935f38370008defb0d
😎 Deploy Preview https://deploy-preview-4007--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit b888718
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66043193257791000866fa0e
😎 Deploy Preview https://deploy-preview-4007--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (8a335bd) to head (b888718).
Report is 263 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d5c36...b888718. Read the comment docs.

@sedghi
Copy link
Member

sedghi commented Apr 10, 2024

I can't reproduce this anymore. Can you record a video or something on https://viewer-dev.ohif.org/tmtv?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.334240657131972136850343327463

@sedghi
Copy link
Member

sedghi commented May 29, 2024

Does this still happen? @jenny-hm-lee

@jenny-hm-lee
Copy link

@sedghi ,
Since OHIF's change on the colourmap, this bug does not exist anymore. This PR is not needed anymore.

@sedghi sedghi closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants