feat: Add customization merge, append or replace functionality #3871
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return newValue; | ||
| } | ||
|
|
||
| return mergeWith(oldValue || {}, newValue, mergeCustomizer.bind(null, mergeType)); |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
There was a problem hiding this comment.
@wayfarer3130 please take a look at this github security risk notice
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3871 +/- ##
==========================================
- Coverage 46.23% 44.44% -1.80%
==========================================
Files 78 80 +2
Lines 1276 1332 +56
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 587 +39
- Partials 138 153 +15
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Context
This is a tiny feature to add the ability to merge instead of replacing within the customization service. The eventual intent is to add more sophisticated merge capabilities, but for now, a simple merge, replace or append is provided.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment