-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(getPixelSpacingInformation): treat negative pixel spacing #3860
fix(getPixelSpacingInformation): treat negative pixel spacing #3860
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3860 +/- ##
==========================================
- Coverage 46.23% 44.44% -1.80%
==========================================
Files 78 80 +2
Lines 1276 1332 +56
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 587 +39
- Partials 138 153 +15
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
can you try removing the whole ultrasound enhanced region logic here, and upgrade cs3d since that implements it properly |
@pedrokohler can you try latest master and let me know if you need this fix or not |
Yes, it looks like it's fixed. I'm closing the PR |
Context
Currently negative values of pixel spacing aren't being properly treated at OHIF and this inverts the image. The solution is to force them positive.
Changes & Results
Before:
After:
Testing
Manually tested.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment