feat(hp): Add displayArea option for Hanging protocols and example with Mamo #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3808 +/- ##
==========================================
- Coverage 46.23% 44.41% -1.83%
==========================================
Files 78 80 +2
Lines 1276 1333 +57
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 588 +40
- Partials 138 153 +15 ☔ View full report in Codecov by Sentry. |
Passing run #4007 ↗︎
Details:
Review all test suite changes for PR #3808 ↗︎ |
|||||||||||||||
sedghi
reviewed
Nov 27, 2023
sedghi
reviewed
Nov 27, 2023
sedghi
reviewed
Nov 27, 2023
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
sedghi
reviewed
Nov 27, 2023
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
logic and documentation Refactor the `hpCompare.ts` file to enhance the study comparison logic for hanging protocols. Specifically, the change ensures that the `attribute` value obtained from the second study is not null, thus improving the accuracy of the comparison. This modification is beneficial for accurately categorizing and ranking different studies based on their attributes. Additionally, update the documentation in the `hpModule.md` file to provide clearer explanation and examples for the optional `from` attribute in the hanging protocol module. The revised documentation clarifies how to retrieve attributes from various objects such as the active study, list of studies, or display sets. These improvements enhance the functionality and usability of hanging protocols, making it easier for users to compare and customize protocols based on study attributes.
wayfarer3130
changed the title
Closed
sedghi
reviewed
May 27, 2024
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
sedghi
approved these changes
May 29, 2024
sedghi
changed the title
|
Can you post a link to the Mamo example? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a mammography hanging protocol, mostly as a test/demonstration code.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment