Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll in Thumbnail with one finger #3628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MkeyhaniM
Copy link

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit c3714fe
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64f21b371cf6940008064406
😎 Deploy Preview https://deploy-preview-3628--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64f883d4837c440a9e3c5f09
😎 Deploy Preview https://deploy-preview-3628--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #3628 (c3714fe) into master (b170e7f) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3628   +/-   ##
=======================================
  Coverage   42.54%   42.54%           
=======================================
  Files          80       80           
  Lines        1462     1462           
  Branches      340      340           
=======================================
  Hits          622      622           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01500a2...c3714fe. Read the comment docs.

@MkeyhaniM
Copy link
Author

MkeyhaniM commented Sep 1, 2023

I just wrote a module from swiperjs , that will help to soft scroll in Thumbnail's components in little devices.

@sedghi
Copy link
Member

sedghi commented Sep 6, 2023

can you update the PR description? what was the behaviour and what happens now with this PR?

@sedghi sedghi self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants