feat hp search recover from incomplete or missing series/stages #3538
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3538 +/- ##
==========================================
+ Coverage 42.75% 42.87% +0.11%
==========================================
Files 82 82
Lines 1450 1453 +3
Branches 338 338
==========================================
+ Hits 620 623 +3
Misses 667 667
Partials 163 163
Continue to review full report in Codecov by Sentry.
|
1 failed tests on run #3370 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| OHIF HP > Should navigate next/previous stage |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
| studies: this.studies, | ||
| activeStudy, | ||
| displaySets, | ||
| }); | ||
| this._setProtocol(matchedProtocol); | ||
| let nthBestMatch = 1; |
There was a problem hiding this comment.
You should just throw the exception if a specific protocol is specified
| } | ||
| } else { | ||
| stage.status = 'disabled'; | ||
| } catch (e) { |
There was a problem hiding this comment.
I think you should avoid touching this code here.
| } | ||
| } | ||
|
|
||
| // it means there is no valid stage | ||
| if (failureCounter === stages.length) { |
There was a problem hiding this comment.
Here you can just iterate over the stages and see if there is a passive or enabled one, rather than throwing.
Context
Hanging protocol approach must consider rollback search in case no display set match or stages for matched protocol.
If that occurs it will try the next best match.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment