Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): cornerstone-wado-image-loader@^4.13.2 #3431

Closed
wants to merge 4 commits into from

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented May 31, 2023

cornerstone-wado-image-loader

  • @ohif/core: ^4.2.1 → ^4.13.2
  • @ohif/extension-cornerstone: ^4.2.1 → ^4.13.2
  • @ohif/extension-vtk: ^4.2.1 → ^4.13.1, ^4.2.1 → ^4.13.2
  • @ohif/viewer: ^4.2.1 → ^4.13.2

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

cornerstone-wado-image-loader
  * @OHIF/core: ^4.2.1 → ^4.13.1
  * @ohif/extension-cornerstone: ^4.2.1 → ^4.13.1
  * @ohif/extension-vtk: ^4.2.1 → ^4.13.1, ^4.2.1 → ^4.13.1
  * @ohif/viewer: ^4.2.1 → ^4.13.1
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #3431 (0b5ddbb) into v2-legacy (5109db6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2-legacy    #3431   +/-   ##
==========================================
  Coverage      11.93%   11.93%           
==========================================
  Files            306      306           
  Lines           8443     8443           
  Branches        1678     1678           
==========================================
  Hits            1008     1008           
  Misses          5949     5949           
  Partials        1486     1486           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5109db6...0b5ddbb. Read the comment docs.

@cypress
Copy link

cypress bot commented May 31, 2023

1 failed tests on run #3454 ↗︎

1 75 0 0 Flakiness 0

Details:

Update dependency: cornerstone-wado-image-loader@4.13.2
Project: Viewers Commit: 0b5ddbbfbb
Status: Failed Duration: 06:02 💡
Started: Aug 15, 2023 7:37 PM Ended: Aug 15, 2023 7:43 PM
Failed  cypress/integration/common/OHIFCornerstoneToolbar.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Toolbar > checks if Levels tool will change the contrast and brightness of an image in the viewport Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for viewer-v2-legacy ready!

Name Link
🔨 Latest commit 0b5ddbb
🔍 Latest deploy log https://app.netlify.com/sites/viewer-v2-legacy/deploys/64dbd2907641360008591248
😎 Deploy Preview https://deploy-preview-3431--viewer-v2-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cornerstone-wado-image-loader
  * @OHIF/core: ^4.13.1 → 4.13.2
  * @ohif/extension-cornerstone: ^4.13.1 → 4.13.2
  * @ohif/extension-vtk: ^4.13.1 → 4.13.2, ^4.13.1 → 4.13.2
  * @ohif/viewer: ^4.13.1 → 4.13.2
@igoroctaviano igoroctaviano changed the title Update dependency: cornerstone-wado-image-loader@^4.13.1 Update dependency: cornerstone-wado-image-loader@^4.13.2 Aug 15, 2023
@igoroctaviano igoroctaviano changed the title Update dependency: cornerstone-wado-image-loader@^4.13.2 build(deps-dev): cornerstone-wado-image-loader@^4.13.2 Aug 15, 2023
@sedghi
Copy link
Member

sedghi commented May 29, 2024

Do you need this @igoroctaviano

@igoroctaviano
Copy link
Contributor Author

Do you need this @igoroctaviano

I think now IDC fork is completely detached from this legacy branch. Feel free to close it. Thanks!

@sedghi sedghi closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants