-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Toggle different study #3370
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ohif-platform-viewer canceled.
|
✅ Deploy Preview for ohif-platform-docs canceled.
|
// Just use the protocol id as the toggle id for toggling | ||
// as the stage shouldn't matter, and one wants to restore even across | ||
// active studies. | ||
const toggleID = protocolId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now possible to toggle on a hanging protcool with multiple stages, and then it won't toggle off until a different hanging protocol is applied or the toggle is directly called. That allows for toggling on a mode such as MPR, and having commands which either apply a given stage or toggle the stage on if it is off, and those same commands will toggle the HP off.
Codecov Report
@@ Coverage Diff @@
## master #3370 +/- ##
==========================================
- Coverage 46.23% 45.95% -0.29%
==========================================
Files 78 78
Lines 1276 1284 +8
Branches 312 314 +2
==========================================
Hits 590 590
- Misses 548 554 +6
- Partials 138 140 +2
Continue to review full report in Codecov by Sentry.
|
Passing run #3609 ↗︎
Details:
Review all test suite changes for PR #3370 ↗︎ |
✅ Deploy Preview for ohif-dev canceled.
|
@wayfarer3130 my PR which reduces the complexity of viewportGrid should be reviewed/merged first before this since that is the way to go forward |
I can't reproduce what you mentioned in the Context in the PR description, it shows the first DS as you wanted CleanShot.2023-09-18.at.11.04.29.mp4 |
I gave it another shot, but couldn't replicate the problem. So, I'll hold off on merging this for now until we can reproduce it step by step. |
Context
Drag and drop of a different study to the MPR mode, and then turning off the MPR mode should still work and preserve the old hanging protocol correctly even if the active study has changed.
Changes & Results
It is probably difficult to see this change in the current version of OHIF because once a study is active in terms of the hanging protocol, there isn't an option to change which study is active.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment