feat: added reviewport set for toolgroup such as MPR #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs canceled.
|
✅ Deploy Preview for ohif-platform-viewer canceled.
|
Codecov Report
@@ Coverage Diff @@
## v3-stable #3298 +/- ##
==============================================
+ Coverage 25.15% 37.37% +12.21%
==============================================
Files 119 85 -34
Lines 2862 1402 -1460
Branches 555 309 -246
==============================================
- Hits 720 524 -196
+ Misses 1856 707 -1149
+ Partials 286 171 -115 see 76 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sedghi
reviewed
Apr 5, 2023
| @@ -471,6 +473,29 @@ function commandsModule({ servicesManager, commandsManager }) { | |||
|
|
|||
| viewport.render(); | |||
| }, | |||
| resetToolGroupVolumeViewports: ({ toolGroupId }) => { | |||
There was a problem hiding this comment.
so where is this being used? I don't see it anywhere
|
@Ouwen Also for this one, any one free you have to work on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This adds the ability to reset viewports at the toolgroup level. One common use case is MPR.
Changes & Results
Adds a new command called
resetToolGroupVolumeViewportsTesting
run this in the window after playing with MPR
commandsManager.runCommand('resetToolGroupVolumeViewports', { toolGroupId: 'mpr' })this depends on this CS3D PR
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment