[WIP] feat: Save DICOM SR to the same series #3273
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for ohif-platform-viewer failed.
|
Codecov Report
@@ Coverage Diff @@
## master #3273 +/- ##
==========================================
- Coverage 42.93% 37.34% -5.59%
==========================================
Files 80 85 +5
Lines 1444 1403 -41
Branches 338 310 -28
==========================================
- Hits 620 524 -96
- Misses 661 707 +46
- Partials 163 172 +9
... and 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
wayfarer3130
force-pushed
the
feat/save-same-series
branch
from
ff03a87
to
24d8e59
Compare
wayfarer3130
force-pushed
the
feat/save-same-series
branch
from
24d8e59
to
b995a78
Compare
|
@wayfarer3130 note that it is not the right DICOM practice to overwrite existing content. What if the prior version of the SR has already been used somewhere, is referenced from somewhere, or is indexed somewhere? I understand sometime some deviation and compromises are unavoidable, but at the very least it should be possible to disable this feature, and it should be communicated to the user that an existing instance is being overwritten. In general, I believe when using SR the idea is to use If you have not yet read the section "Copies and Versions" of @dclunie "DICOM Structured Reporting" book, you are very strongly encouraged to do so! |
|
@fedorov from a quick look I think @wayfarer3130 is not overwriting the SR instance, but adding the new instance to the same series as existing SRs. I don't know if this is allowed in the standard (not sure why it wouldn't be) but if there's a chain of edits of the "same" SR then to me it sounds good to put them in the same series. |
@fedorov - yes, I'm adding to the existing series. Ideally adding a deprecation reference to the earlier instances, but that isn't something I've implemented yet (I have to look up in the standard what the tags are for that - I've NEVER seen them used, but have seen them in the standard). |
|
"adding the new instance to the same series as existing SRs. I don't know if this is allowed in the standard (not sure why it wouldn't be)" - criteria for same Series are defined in the standard here - same equipment may be a barrier here, since arguably two deployed instances of the same viewer used on different computers at different times are not really "the same equipment". |
|
@wayfarer3130 would you be interested to get together to discuss this feature together with the members of the Imaging Data Commons team (David Clunie, Steve Pieper and myself)? We would be interested in such a discussion. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
extensions/cornerstone-dicom-sr/src/viewports/OHIFCornerstoneSRViewport.tsx
Fixed
Show fixed
Hide fixed
extensions/cornerstone-dicom-sr/src/viewports/OHIFCornerstoneSRViewport.tsx
Fixed
Show fixed
Hide fixed
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@wayfarer3130 Could you please revisit this after the new replies ? Thanks |
Context
It becomes very confusing to have a lot of series all with the same series description, but differing date/times and content.
This PR changes the save so items get saved to the same series.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment