Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] feat: switch to oidc-client-ts since our current oidc-client is deprecated #3041

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Nov 25, 2022

switch to oidc-client-ts since the oidc-client is deprecated. It significantly reduces the bundle size as well. However, it seems like it only supports response_type of code and for our current id_token token we need to add client_secret as well

https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md
perarnborg/vuex-oidc#187
authts/oidc-client-ts#152
authts/oidc-client-ts#571

Old client in build analyzer
image

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit cfd64c5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/638013111848660008a0d7d5

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for ohif-platform-viewer ready!

Name Link
🔨 Latest commit cfd64c5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-viewer/deploys/6380131135eb1900086ccf74
😎 Deploy Preview https://deploy-preview-3041--ohif-platform-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sedghi sedghi changed the title [Draft] feat: remove oidc-client since it is deprecated [Draft] feat: switch to oidc-client-ts since our current oidc-client is deprecated Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #3041 (cfd64c5) into v3-stable (9f1e813) will increase coverage by 14.82%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v3-stable    #3041       +/-   ##
==============================================
+ Coverage      25.15%   39.98%   +14.82%     
==============================================
  Files            119       96       -23     
  Lines           2862     2021      -841     
  Branches         555      420      -135     
==============================================
+ Hits             720      808       +88     
+ Misses          1856      990      -866     
+ Partials         286      223       -63     
Impacted Files Coverage Δ
...tform/core/src/services/CineService/CineService.js 12.50% <0.00%> (-6.25%) ⬇️
.../services/MeasurementService/MeasurementService.js 47.23% <0.00%> (-1.96%) ⬇️
...ore/src/services/_shared/pubSubServiceInterface.js 80.00% <0.00%> (-1.82%) ⬇️
platform/core/src/classes/CommandsManager.js 90.69% <0.00%> (-1.14%) ⬇️
platform/core/src/classes/MetadataProvider.js 4.54% <0.00%> (-0.72%) ⬇️
platform/viewer/src/index.js 0.00% <0.00%> (ø)
platform/viewer/src/appInit.js 0.00% <0.00%> (ø)
platform/core/src/utils/index.js 100.00% <0.00%> (ø)
platform/core/src/utils/isImage.js 100.00% <0.00%> (ø)
platform/core/src/services/ServicesManager.js 100.00% <0.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd962f...cfd64c5. Read the comment docs.

@cypress
Copy link

cypress bot commented Nov 25, 2022



Test summary

20 0 0 0


Run details

Project Viewers
Status Passed
Commit cfd64c5
Started Nov 25, 2022 1:04 AM
Ended Nov 25, 2022 1:06 AM
Duration 01:39 💡
OS Linux Debian - 11.3
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sedghi sedghi changed the base branch from v3-stable to master June 19, 2023 13:34
@sedghi sedghi self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant