Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] scripts/update-schema-id.sh #3814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TakahikoKawasaki
Copy link

This script updates the schema IDs in the following YAML files:

  • schemas/v{major}.{minor}/schema.yaml
  • schemas/v{major}.{minor}/schema-base.yaml

and generates the following JSON files from the updated YAML files:

  • schemas/v{major}.{minor}/schema.json
  • schemas/v{major}.{minor}/schema-base.json

This script updates the schema IDs in the following YAML files:

- schemas/v{major}.{minor}/schema.yaml
- schemas/v{major}.{minor}/schema-base.yaml

and generates the following JSON files from the updated YAML files:

- schemas/v{major}.{minor}/schema.json
- schemas/v{major}.{minor}/schema-base.json
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the script with -v 3.1 and it worked fine.

Running with -v 3.0 showed problems:

  • schema.yaml was not updated
  • schema-base.yaml was created empty
  • schema-base.json was created with content null

@ralfhandl
Copy link
Contributor

Hi @TakahikoKawasaki,

Thanks for providing the script.

The script works fine for the v3.1 case with separate schema and schema-base, and fail for the v3.0 case where there is only schema.

Would you mind adding this distinction to the scripts?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants