Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant and outdated example from libexpr-c documentation #10724

Merged
merged 1 commit into from
May 22, 2024

Conversation

prednaz
Copy link
Contributor

@prednaz prednaz commented May 16, 2024

Motivation

the example in the libexpr-c documenation is outdated, does not compile anymore, and is redundant with the Embedding the Nix Evaluator example, which has been kept up to date. so this pull request just replaces the outdated redundant example with a link to the other example.

it is rendered as follows.

image

This work is sponsored by Antithesis

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@prednaz prednaz requested a review from edolstra as a code owner May 16, 2024 00:50
@github-actions github-actions bot added the c api Nix as a C library with a stable interface label May 16, 2024
@edolstra edolstra requested review from roberth and removed request for edolstra May 16, 2024 07:51
@roberth
Copy link
Member

roberth commented May 20, 2024

Good idea, but the anchor doesn't look stable. It looks like anchor ids are supported, so we should apply those to all headers. Then we'll have a stable link.

@prednaz
Copy link
Contributor Author

prednaz commented May 21, 2024

yes, you are quite right there. thanks a lot!

@roberth
Copy link
Member

roberth commented May 22, 2024

Thanks!

@roberth roberth merged commit bd7a074 into NixOS:master May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c api Nix as a C library with a stable interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants