reword documentation on nix-copy-closure
#10709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one sentence per line - be more precise with respect to which Nix stores are being accessed - make a clear distinction between store paths and store objects - add links to definitions of terms
fricklerhandwerk
force-pushed
the
reword-nix-copy-closure-docs
branch
from
ca3316f
to
130d552
Compare
roberth
reviewed
May 20, 2024
roberth
reviewed
May 21, 2024
|
@roberth thanks for the review, the whole "which machine is which" business really needed clarification. Last round now? |
roberth
reviewed
May 21, 2024
|
Ah good, you helped me discover a major error documentation. |
|
End-user, nix novice here. A naive read of the current versions flows quite well for me. I appreciate the changes to clarify how to use this tool! |
roberth
approved these changes
May 21, 2024
roberth
reviewed
May 21, 2024
| [`--gzip`] | ||
| [`--include-outputs`] | ||
| [`--use-substitutes` | `-s`] | ||
| [`-v`] | ||
| _user@machine_ _paths_ | ||
| [_user_@]_machine_[:_port_] _paths_ |
There was a problem hiding this comment.
Fwiw, SSH would call this a "destination" and that would be absolutely awful for us to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Based on discussion with @eflanagan0 and @wamirez.
Related: #10708
Context
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.