New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try fix workflow #584
base: develop
Are you sure you want to change the base?
Try fix workflow #584
Conversation
This issue is different! Sensational! If you have time, can you take look on the secret on the neurotechx organization @sylvchev? Maye someone outside of the moabb project may have updated it on neurotechx and we didn't see it. |
Yes, the idea is to have the git sha of the HEAD written somewhere in the generated HTML files so that we are sure that there is always a difference between two pushes to the gh pages repo. |
Why are we not using moabb/.github/workflows/docs.yml Line 112 in 29c0423
|
Why is the cache named "Cache datasets and docs"? I don't see where we are caching the datasets |
I think we should use a "short lived cache" for the docs build: https://github.com/actions/cache/blob/v3.3.3/caching-strategies.md#creating-a-short-lived-cache Otherwise there might be interactions between different workflow runs |
…n the deeplearning dependencies)
Hey @PierreGtch! I tried something because I wanted to see if you work. You can revert if it does not work. I gave you admin permission to access the moabb secret keys. This could help the GitHub.io deployment. I don't have permission from the organization NeuroTechX, so we need to wait for @sylvchev |
id: cache-docs | ||
uses: actions/cache@v3 | ||
with: | ||
key: docs-build-${{ github.run_id }}-${{ github.run_attempt }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key: docs-build-${{ github.run_id }}-${{ github.run_attempt }} | |
key: docs-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoiding cache explode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used docs-build-${{ github.run_id }}-${{ github.run_attempt }}
to have one different cache for every new CI run. Otherwise, some previously existing builds will be re-used. Is this what we want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually yes, in almost all cases we want to reuse installed pip/poetry packages and downloaded datasets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need new secret keys?
No description provided.