Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix workflow #584

Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from
Draft

Conversation

PierreGtch
Copy link
Collaborator

No description provided.

@bruAristimunha
Copy link
Collaborator

This issue is different! Sensational!

If you have time, can you take look on the secret on the neurotechx organization @sylvchev? Maye someone outside of the moabb project may have updated it on neurotechx and we didn't see it.

@PierreGtch
Copy link
Collaborator Author

Yes, the idea is to have the git sha of the HEAD written somewhere in the generated HTML files so that we are sure that there is always a difference between two pushes to the gh pages repo.

@PierreGtch
Copy link
Collaborator Author

Why are we not using actions/cache/restore@v3 to get the build cache here:

uses: actions/cache@v3

See here: https://github.com/actions/cache/blob/v3.3.3/caching-strategies.md#make-cache-read-only--reuse-cache-from-centralized-job

@PierreGtch
Copy link
Collaborator Author

Why is the cache named "Cache datasets and docs"? I don't see where we are caching the datasets

@PierreGtch
Copy link
Collaborator Author

I think we should use a "short lived cache" for the docs build: https://github.com/actions/cache/blob/v3.3.3/caching-strategies.md#creating-a-short-lived-cache

Otherwise there might be interactions between different workflow runs

@bruAristimunha
Copy link
Collaborator

Hey @PierreGtch!

I tried something because I wanted to see if you work. You can revert if it does not work. I gave you admin permission to access the moabb secret keys. This could help the GitHub.io deployment.

I don't have permission from the organization NeuroTechX, so we need to wait for @sylvchev

id: cache-docs
uses: actions/cache@v3
with:
key: docs-build-${{ github.run_id }}-${{ github.run_attempt }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: docs-build-${{ github.run_id }}-${{ github.run_attempt }}
key: docs-build

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoiding cache explode

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used docs-build-${{ github.run_id }}-${{ github.run_attempt }} to have one different cache for every new CI run. Otherwise, some previously existing builds will be re-used. Is this what we want?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually yes, in almost all cases we want to reuse installed pip/poetry packages and downloaded datasets

Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need new secret keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants