Remove coupling from merge plugin and aura #7044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
May 22, 2024
| @@ -9,6 +9,7 @@ | |||
| <ProjectReference Include="..\Nethermind.Blockchain\Nethermind.Blockchain.csproj" /> | |||
| <ProjectReference Include="..\Nethermind.Core\Nethermind.Core.csproj" /> | |||
| <ProjectReference Include="..\Nethermind.Consensus\Nethermind.Consensus.csproj" /> | |||
| <ProjectReference Include="..\Nethermind.Init\Nethermind.Init.csproj" /> | |||
There was a problem hiding this comment.
yes, it was implicitly referenced by Merge.Plugin -> Aura -> Init.
So when i broke the coupling, it became needed
MarekM25
reviewed
May 22, 2024
MarekM25
reviewed
May 22, 2024
| @@ -73,6 +73,11 @@ protected override PostMergeBlockProducerFactory CreateBlockProducerFactory() | |||
| _blocksConfig, | |||
| _api.LogManager); | |||
|
|
|||
| protected override IBlockFinalizationManager InitializeMergeFinilizationManager() | |||
| { | |||
| return new MergeFinalizationManager(_blockFinalizationManager, _api.FinalizationManager, _poSSwitcher); | |||
There was a problem hiding this comment.
Shouldn't be AuraMergeFinalizationManager here?
|
|
||
| public AuRaMergeFinalizationManager(IManualBlockFinalizationManager manualBlockFinalizationManager, IBlockFinalizationManager? blockFinalizationManager, IPoSSwitcher poSSwitcher) : base(manualBlockFinalizationManager, blockFinalizationManager, poSSwitcher) | ||
| { | ||
| _auRaBlockFinalizationManager = blockFinalizationManager as IAuRaBlockFinalizationManager; |
There was a problem hiding this comment.
Does it make to instantiate this and put blockFinalizationManager as anything else than IAuRaBlockFinalizationManager ? If not why not make it explicit in constructor? And why use as instead of proper casting and throwing exceptions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes