-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override RLP decoders with ones from plugins; fix op decoder #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
approved these changes
May 2, 2024
Haha, didn't see was draft :) |
LukaszRozmej
reviewed
May 2, 2024
…); fix op decoder
alexb5dh
reviewed
May 9, 2024
src/Nethermind/Nethermind.Blockchain/Receipts/ReceiptsRootCalculator.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Proof/ProofRpcModule.cs
Outdated
Show resolved
Hide resolved
...Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V63/Messages/ReceiptsMessageSerializer.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Optimism.Plugin.Test/ReceiptDecoderTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/ReceiptArrayStorageDecoder.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloadContext.cs
Outdated
Show resolved
Hide resolved
flcl42
force-pushed
the
receipt-decoder-di
branch
from
May 13, 2024 12:29
abd9d60
to
9482a82
Compare
LukaszRozmej
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have someone from optimism stack review it too.
...ethermind/Nethermind.AccountAbstraction.Test/Network/UserOperationsMessageSerializerTests.cs
Show resolved
Hide resolved
flcl42
force-pushed
the
receipt-decoder-di
branch
from
May 14, 2024 11:16
92dc44a
to
2a8830d
Compare
It's done according to what a learned from @protolambda's answers |
jmederosalvarado
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Remarks
We need to do the same for tx receipt storage, I guess. But maybe later