[Ready for Review] add attempt_ok flag so that UI will not show up unknown node #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinyu
changed the title
romain-intel
reviewed
May 9, 2024
metaflow/clone_util.py
Outdated
| @@ -66,6 +66,12 @@ def clone_task_helper( | |||
| type="attempt", | |||
| tags=metadata_tags, | |||
| ), | |||
| MetaDatum( | |||
| field="attempt_ok", | |||
| value=True, # During clone, the task is always considered successful. | |||
There was a problem hiding this comment.
I think it should be str(True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
attempt_okattribute is not used within metaflow runtime but is needed for UI to correctly display the status of a node. For example, in metaflow-service repo here, ifattempt_okis not set, then the status become unknown.For example, like this:
