AspnetCore 2.0 sample #2878
AspnetCore 2.0 sample #2878
Conversation
|
|
| @@ -0,0 +1,15 @@ | |||
| using Microsoft.AspNetCore; | |||
There was a problem hiding this comment.
Can we move the using statements inside the namespace, to align with the rest of the Nancy code
| @@ -0,0 +1,31 @@ | |||
| using Microsoft.AspNetCore.Builder; | |||
There was a problem hiding this comment.
Can we move the using statements inside the namespace, to align with the rest of the Nancy code
| app.UseOwin().UseNancy(); | ||
|
|
||
| app.Run(async (context) => | ||
| { |
There was a problem hiding this comment.
The indentation is a bit off here
There was a problem hiding this comment.
Why even include this block of code? The Nancy middleware should handle the request, so this should never be hit.
| app.Run(async (context) => | ||
| { | ||
| await context.Response.WriteAsync("Hello World!"); | ||
| }); |
There was a problem hiding this comment.
The indentation is a bit off here
| public void Configure(IApplicationBuilder app, IHostingEnvironment env) | ||
| { | ||
| if (env.IsDevelopment()) | ||
| app.UseDeveloperExceptionPage(); |
There was a problem hiding this comment.
We need to wrap this line in curly-braces so align with the rest of the code
Pull request amendments.
|
@thecodejunkie, @khellang, thank you for your feedback, the amendments have been committed as per your comments. |
Prerequisites
Description
Added AspnetCore 2.0 hosted sample