-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate requirements #174
base: dev
Are you sure you want to change the base?
Conversation
Fixes ModuleNotFound issue with pyinstaller
Any reason this is hanging around for over a year? |
Maybe @MatthewScholefield or @krisgesling can review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nudge, this looks like a great change.
One question below
@@ -1,44 +0,0 @@ | |||
absl-py==0.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What were the rest of these requirements for?
Do we need a new requirements/dev.txt
or something?
@@ -1,4 +1,4 @@ | |||
numpy==1.16 | |||
numpy==1.16.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be bumped to 1.16.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also h5py<3.0.0
fixes a runtime problem
Be careful, those changes generate a regression: wheel cannot build anymore, since setup.py needs requirements/prod.txt to be part of the package and is not. I revert the change and propose to remove entirely requirements/prod.txt and use correctly setup.py list: https://gitlab.com/liant-sasu/mycroft-precise/-/merge_requests/13 |
@ShamoX https://github.com/jessecooper/mycroft-precise/tree/dev/requirements |
This removes the requirements.txt and package list in setup.py in favor of the list in requirements/prod.txt and should resolve #172
It also bumps the numpy version to 1.16.2 to match the version listed in requirements.txt which should fix some errors with pyinstaller.