Improve test coverage #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewScholefield
force-pushed
the
feature/improve-tests-1
branch
from
7286ce1
to
c68fc47
Compare
chrisveilleux
approved these changes
Apr 29, 2020
forslund
reviewed
Apr 30, 2020
There was a problem hiding this comment.
For me the test_listen test fails
> assert len(glob(join(activations_folder, '*.wav'))) == 1
E AssertionError: assert 0 == 1
E + where 0 = len([])
E + where [] = glob('/tmp/tmpyxkeafkq/activations/*.wav')
E + where '/tmp/tmpyxkeafkq/activations/*.wav' = join('/tmp/tmpyxkeafkq/activations', '*.wav')
test/scripts/test_listen.py:40: AssertionError
Complete test log: https://termbin.com/uto1
| @@ -0,0 +1,40 @@ | |||
| #!/usr/bin/env python3 | |||
| # Copyright 2019 Mycroft AI Inc. | |||
|
Does it consistently happen?
…On Thu, Apr 30, 2020, 2:32 AM Åke ***@***.***> wrote:
***@***.**** commented on this pull request.
For me the test_listen test fails
> assert len(glob(join(activations_folder, '*.wav'))) == 1
E AssertionError: assert 0 == 1
E + where 0 = len([])
E + where [] = glob('/tmp/tmpyxkeafkq/activations/*.wav')
E + where '/tmp/tmpyxkeafkq/activations/*.wav' = join('/tmp/tmpyxkeafkq/activations', '*.wav')
test/scripts/test_listen.py:40: AssertionError
Complete test log: https://termbin.com/uto1
------------------------------
In test/scripts/test_listen.py
<#154 (comment)>
:
> @@ -0,0 +1,40 @@
+#!/usr/bin/env python3
+# Copyright 2019 Mycroft AI Inc.
2020
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#154 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM2KS5MDI3IFFOJRO4VMQLRPESRRANCNFSM4MSN7R5A>
.
|
|
Yes every time. I've made sure to rerun the precise setup.py aswell |
This allows clean exiting of the runner when used with a ReadWriteStream
This ensures rounding is handled properly. This also fixes a bug where 1.0 would be mapped to 32768 and converted back as -1
It's possible that this could cause a model to activate less at the 0.5 threshold because the center wasn't adjusted properly
Fixtures are used consistently A new TempFolder class has been created for reusability A session-wide trained_model fixture has been added to speed up testing
MatthewScholefield
force-pushed
the
feature/improve-tests-1
branch
from
c68fc47
to
4cc1efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors and improves test coverage. As a result, some issues with those tests were resolved.