Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requirements mismatch as defined in multiple locations #172

Open
krisgesling opened this issue Aug 5, 2020 · 2 comments · May be fixed by #174
Open

Requirements mismatch as defined in multiple locations #172

krisgesling opened this issue Aug 5, 2020 · 2 comments · May be fixed by #174

Comments

@krisgesling
Copy link
Contributor

There seems to be a mismatch of requirements between setup.py, requirements.txt and requirements/prod.txt

eg numpy==1.16 vs 1.16.2

Is there a reason for the three different lists of requirements? Can we consolidate?
@forslund
Copy link
Collaborator

forslund commented Aug 5, 2020

As far as I remember the requirements.txt should be removed and requirements/prod.txt be used in it's place. The requirements/prod.txt was extracted from the setup.py (as this was the minimum list of requirements, while requirements.txt was the result of a environment freeze)

@forslund
Copy link
Collaborator

forslund commented Aug 5, 2020

Been trying to figure out if I had a reason to setting it to 1.16 or if I really meant to set it as ~=1.16. In any case fixing it to 1.16.2 seems to be ok in all tests I've made here.

@forslund forslund linked a pull request Aug 5, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate requirements forslund/mycroft-precise
2 participants
@forslund @krisgesling