Forbid empty Strings #636
Open
Forbid empty Strings #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MobilityData#600 https://mobilitydata-io.slack.com/archives/CNXA9ASBV/p1715598631556219 Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>
|
Before submitting to a vote, do you think that change could be in 3.2 ? It is technically a breaking change, but I think it worth it to improve the GBFSv3. |
|
Hi @tdelmas, I think we should avoid making an exception to the change process. If the community wants to make the change in v3.2-RC, we could consider:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #600
See also https://mobilitydata-io.slack.com/archives/CNXA9ASBV/p1715598631556219
What is the proposal?
Specify that strings (including IDs) MUST NOT be empty.
Is this a breaking change?
Which files are affected by this change?
All of them (because of the IDs)
Examples of affected feeds
https://mobilitydata-io.slack.com/archives/CNXA9ASBV/p1708449123435399?thread_ts=1708429919.754579&cid=CNXA9ASBV