Fix: Click Position and Hit Detection on iPhone Mini #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/Mapsui into FixTouchOnIPhoneMini
inforithmics
changed the title
inforithmics
commented
May 20, 2024
| @@ -13,7 +13,7 @@ | |||
| <key>LSRequiresIPhoneOS</key> | |||
| <true/> | |||
| <key>MinimumOSVersion</key> | |||
| <string>10.0</string> | |||
| <string>13.0</string> | |||
There was a problem hiding this comment.
Discovered that the min ios Version has changed to version 13
pauldendulk
requested changes
May 20, 2024
|
|
||
| public class TouchPointSample : ISample | ||
| { | ||
| private static Map _map; |
There was a problem hiding this comment.
Why does the _map need to be static?
| public class TouchPointSample : ISample | ||
| { | ||
| private static Map _map; | ||
| private TextBoxWidget _label; |
There was a problem hiding this comment.
Not sure if you want this to be merged because it is mainly to show a bug. But if this is merged we should get rid of nullable and reassignment warnings.
inforithmics
changed the title
inforithmics
changed the title
inforithmics
changed the title
pauldendulk
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done: