Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] convert README to markdown + updates #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gaelforget
Copy link
Member

No description provided.

@gaelforget gaelforget changed the title convert README to markdown + updates [WIP] convert README to markdown + updates Jun 18, 2021
@mjlosch
Copy link
Member

mjlosch commented Jun 21, 2021

@gaelforget isn't commit 04c7cc0 the same as #42 ?

@gaelforget
Copy link
Member Author

@gaelforget isn't commit 04c7cc0 the same as #42 ?

Yes

@gaelforget
Copy link
Member Author

@gaelforget isn't commit 04c7cc0 the same as #42 ?

Yes

My mistake was that I started #42 on master then branched to do this one. I probably could rebase or do over but figured I would just wait for #42 to be merged which would eliminate the duplicate and supposedly you guys would squash merge so it does not matter. Would this work?

@gaelforget
Copy link
Member Author

@gaelforget isn't commit 04c7cc0 the same as #42 ?

Yes

My mistake was that I started #42 on master then branched to do this one. I probably could rebase or do over but figured I would just wait for #42 to be merged which would eliminate the duplicate and supposedly you guys would squash merge so it does not matter. Would this work?

done with merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants