Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MITK_USE_CUDA superbuild flag #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtfcordes
Copy link

Fixes errors during package generation due to unneccessary CUDA dependencies.

@kislinsk
Copy link
Contributor

kislinsk commented Oct 4, 2023

Did you add CUDA as a dependency to your fork? We don't have it but the MITK_USE_<...> variables are kind of reserved and introducing MITK_USE_CUDA just for the sake of explicitly disabling it would make it necessary to add an according exception to the _package_excludes list in CMake/PackageConfigurations/All.cmake.

For example, CMakeExternals/OpenCV.cmake just unconditionally disables CUDA support in OpenCV with -DWITH_CUDA:BOOL=OFF. I guess it would be okay to disable it for Eigen without any additional checks as well, given that you didn't introduce CUDA as dependency in your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants