Details dialog close button #243
Conversation
Signed-off-by: Daniel Maleike <daniel.maleike@stryker.com>
| @@ -37,7 +37,7 @@ QmitkInfoDialog::QmitkInfoDialog(const QList<mitk::DataNode::Pointer>& nodes, QW | |||
| m_SearchButton = new QPushButton("Search (F3)", this); | |||
| m_SearchButton->installEventFilter(this); | |||
| m_TextBrowser = new QTextBrowser(this); | |||
| QPushButton* cancelButton = new QPushButton("Cancel", this); | |||
| QPushButton* m_CloseButton = new QPushButton("Close", this); | |||
There was a problem hiding this comment.
I wouldn't use m_, since this is not a member variable.
There was a problem hiding this comment.
I think using an .ui file would be the right way to go. Also typical buttons like Cancel, and so on may be already available through the Dialog API of Qt instead of creating own buttons.
There was a problem hiding this comment.
I wouldn't use
m_, since this is not a member variable.
Oups, you are right, I did not see that. Yes, the prefix m_ is wrong
There was a problem hiding this comment.
I think using an .ui file would be the right way to go. Also typical buttons like Cancel, and so on may be already available through the Dialog API of Qt instead of creating own buttons.
You are right, .ui files would be an option. However, I did not want to rewrite the widget but only fix a misleading label.
No description provided.