Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datapane embedded #58

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

guerinclement
Copy link
Collaborator

Description

Fixes #57

I made datapane a submodule of eurybia.report.
Following dependencies have been added to make it work:

    "altair>=5.0.0",
    "pyarrow>=9.0.0",
    "chardet>=5.0.0,<6.0.0",
    "lxml>=4.7.1,<5.0.0",
    "micawber>=0.5.3",
    "dominate>=2.7.0,<3.0.0",
    "multimethod>=1.9.0,<2.0.0",

Following dependency have been removed:

    "datapane>=0.16.7",

I had to change some imports such as:

from datapane import ...
import datapane

to

from eurybia.report.datapane import ...
import eurybia.report.datapane

Installing Eurybia now pulls pandas>=2.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I ran the whole suite of unit tests.
The following tests failed :

  • test_generate_fig_univariate_1
  • test_series_dtype_1
  • test_perform_univariate_dataframe_analysis_1

The common causes comes from a change in pandas>=2 type checker functions.
I had to slightly adapt the function series_dtype in eurybia.report.commons to make it work the way it used to be.

Test Configuration:

  • OS: macOS Sonoma 14.4.1
  • Python version: 3.9.6
  • Eurybia version: 1.1.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@guerinclement guerinclement marked this pull request as draft May 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of pandas>=2
2 participants