-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(installer): Add bun as a JS package manager/runtime (windows) #4473
Open
TheBearodactyl
wants to merge
15
commits into
LunarVim:master
Choose a base branch
from
TheBearodactyl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: LostNeophyte <lostneophyte@tuta.io>
…or windows) Bun finally has a version for windows (it's in canary, but it's still available), so I thought I would add bun for the powershell script as well
TheBearodactyl
changed the title
feat(installer): Add bun as a JS package manager/runtime (this time for windows)
feat(installer): Add bun as a JS package manager/runtime (windows)
Jan 20, 2024
kylo252
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can simplify all of this by detecting if bun
is available and use it in install_nodejs_deps()
similar to how we do it in the bash installer.
I think it would look something like this
function install_nodejs_deps() {
try {
if (Get-Command "bun" -ErrorAction SilentlyContinue) {
Set-Alias pkg_manager "bun" -Scope Private
} else {
Set-Alias pkg_manager "npm" -Scope Private
check_system_dep "node"
}
Invoke-Command -ScriptBlock { pkg_manager install --global neovim tree-sitter-cli } -ErrorAction Break
} catch {
print_missing_dep_msg "$dep"
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds bun as a js package manager/runtime in the installer script for windows
How Has This Been Tested?
Just like with the linux installer script, i've run it on my machine, both with and without bun installed.