fix(lazygit): fix too larg size(100000) for lazygit_toogle method #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chase
approved these changes
Nov 9, 2023
kylo252
requested changes
May 14, 2024
There was a problem hiding this comment.
This sounds like a bug in neovide? from :h columns
You can use this command to get the widest
window possible:
:set columns=9999
Minimum value is 12, maximum value is 10000.another idea is to detect if running in a GUI and limit the width/height in that case, see neovide/neovide#919
Comment on lines
+161
to
+162
| width = columns or 300, | ||
| height = lines or 200, |
There was a problem hiding this comment.
using or doesn't do anything, since vim.o.columns value is always has a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In macOS, when I used an nvim-gui like Neovide, when I set up the multigrid feature, eovide will create the stage realistically -- will cause a memory leak by consuming a lot of memory, which will cause the Neovide to get hanging.
Just detect
columnslinesto set plugin toggleterm'swidthandheight, no dependencies.How Has This Been Tested?
:lua require 'lvim.core.terminal'.lazygit_toggle()