Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): add plugins to cmp config #3904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thyseus
Copy link

@thyseus thyseus commented Feb 28, 2023

add commit, vim-dadbot-completion, cmp-tw2css plugins to cmp config

add commit, vim-dadbot-completion and cmp-tw2css plugins to cmp config
@thyseus thyseus changed the title add commit, vim-dadbot-completion, cmp-tw2css plugins to cmp config feat(plugins): add commit, vim-dadbot-completion, cmp-tw2css plugins to cmp config Feb 28, 2023
@thyseus thyseus changed the title feat(plugins): add commit, vim-dadbot-completion, cmp-tw2css plugins to cmp config feat(plugins): add plugins to cmp config Feb 28, 2023
@rebuilt
Copy link
Collaborator

rebuilt commented Mar 20, 2023

Is it for performance reasons that we haven't added everything on this list? https://github.com/hrsh7th/nvim-cmp/wiki/List-of-sources

If the performance hit is negligable, I don't see why we can't add more items to the list of sources.
If adding more sources is noticeable, especially on slow machines, then we should document the expected way completion sources should be added:

lvim.builtin.cmp.formatting.source_names["copilot"] = "(Copilot)"
table.insert(lvim.builtin.cmp.sources, 1, { name = "copilot" })

@thyseus
Copy link
Author

thyseus commented Mar 20, 2023

A similar discussion is going on here:

#2542

unfortunately my lua skills are not high enough to do it :(
thanks a lot for that lines, @rebuilt thats what i needed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants