Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astgnn #376

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Astgnn #376

wants to merge 19 commits into from

Conversation

luiluizi
Copy link
Collaborator

@luiluizi luiluizi commented Dec 5, 2023

只跑了PEMSD4

PEMSD4 libcity ASTGNN
MAE: 18.7511 18.60
RMSE: 29.5769 30.91

对不同的数据集需要设置不同的参数

@aptx1231
Copy link
Member

aptx1231 commented Dec 5, 2023

mape是多少？

aptx1231
aptx1231 reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@aptx1231 aptx1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可能问题比较多？不过这个模型比较复杂，可以解释下为什么需要单独的executor？
dataset最好复用astgcn的dataset

libcity/data/dataset/dataset_subclass/astgnn_dataset.py Outdated Show resolved Hide resolved
libcity/data/dataset/dataset_subclass/astgnn_dataset.py Outdated Show resolved Hide resolved
libcity/data/dataset/dataset_subclass/astgnn_dataset.py Outdated Show resolved Hide resolved
libcity/data/dataset/dataset_subclass/astgnn_dataset.py Outdated Show resolved Hide resolved
libcity/data/dataset/dataset_subclass/astgnn_dataset.py Outdated Show resolved Hide resolved
libcity/executor/astgnn_executor.py Outdated Show resolved Hide resolved
libcity/executor/astgnn_executor.py Show resolved Hide resolved
@aptx1231
Copy link
Member

aptx1231 commented Dec 5, 2023

指标我们一般看的是masked_mae/mape/rmse。
不过pems4和8一般确实也会看不带mased的mae和rmse。

@luiluizi
Copy link
Collaborator Author

luiluizi commented Dec 6, 2023

mape是多少？

PEMSD4 libcity ASTGNN
MAE: 18.7511 18.60
RMSE: 29.5769 30.91
MAPE: 11.82% 12.36%

@luiluizi luiluizi closed this Dec 7, 2023
@luiluizi luiluizi reopened this Dec 7, 2023
@luiluizi
Copy link
Collaborator Author

luiluizi commented Dec 7, 2023

修改后mape为：

PEMSD4 libcity ASTGNN
MAE: 19.1327 18.60
RMSE: 28.1549 30.91
RMSE: 11.9246% 12.36%

@luiluizi luiluizi closed this Jan 8, 2024
@luiluizi luiluizi reopened this Jan 8, 2024
@luiluizi luiluizi closed this Jan 8, 2024
@luiluizi luiluizi reopened this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptx1231 aptx1231 aptx1231 left review comments

@NickHan-cs NickHan-cs Awaiting requested review from NickHan-cs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luiluizi @aptx1231 @NickHan-cs