move to cuda 11.8 with install script #2009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the following analysis is not correct - the latest version seems to work after compiling both common and fp16 only cuda code with -arch=all-major.
Made draft as #2015 has the bits to fix the NaN issues (a bit more refined) without the cuda version update. Will make this into just a cuda version update PR at a later stage.
The recent rc1 issues seem to go away if we compile the cuda fp16 code with-arch=all-major, so I added it tomeson.build. It is added unconditionally since the default is still to use-arch=nativeand the alternative is an attempt to do the equivalent to-arch=all-majorfor cuda versions that don't support it.This requires at least cuda version 11.5, but as we tested with 11.8 I used thisUpdates cuda to 11.8 for the appveyor cuda builds (cudnn unchanged), and given the huge size of the dlls I added an install script based on the directml one.
While testing I also found a bug with the directml install script, probably some recent windows security change makes executables in the same directory unavailable when running it by double clicking, so I removed the lc0.exe check and it will directly install the dlls in the script's directory.