Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add another math method and test #1645

Merged
merged 5 commits into from
May 20, 2024
Merged

Add another math method and test #1645

merged 5 commits into from
May 20, 2024

Conversation

MrBurmark
Copy link
Member

Add prev_pow2 and tests for functions in util/math.hpp

  • This PR is a bugfix, feature
  • It does the following:
    • Fixes missing math tests
    • Adds prev_pow2 at the request of me

artv3
artv3 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@artv3 artv3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should features like this maybe go into CAMP?

@MrBurmark
Copy link
Member Author

You're probably right there.

rhornung67
rhornung67 reviewed May 15, 2024
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation suggestions. The phrase "next smaller" is a little confusing I think.

@MrBurmark @rhornung67
Apply suggestions from code review
fc7316b 
Co-authored-by: Rich Hornung <hornung1@llnl.gov>
MrBurmark
MrBurmark commented May 15, 2024
View reviewed changes
include/RAJA/util/math.hpp Outdated Show resolved Hide resolved
@MrBurmark MrBurmark merged commit c5ed86e into develop May 20, 2024
24 checks passed
@MrBurmark MrBurmark deleted the feature/burmark1/math branch May 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artv3 artv3 artv3 approved these changes

@rhornung67 rhornung67 rhornung67 approved these changes

@adayton1 adayton1 Awaiting requested review from adayton1

@rchen20 rchen20 Awaiting requested review from rchen20

@long58 long58 Awaiting requested review from long58

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrBurmark @artv3 @rhornung67