-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel function information for hip #1123
base: develop
Are you sure you want to change the base?
Conversation
static hipFuncAttributes get_hip_func_attributes(void const *kernel_func) { | ||
static hipFuncAttributes attr = [=]() { | ||
hipFuncAttributes attr; | ||
hipFuncGetAttributes(&attr, kernel_func); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be error checked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking for a HIP_SAFE_CALL macro defined but didn't see one. Do we have one? Should I add one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static unsigned int getKernelScratchBytes( | ||
hipFuncAttributes const &hip_func_attributes) { | ||
return hip_func_attributes.localSizeBytes; | ||
} | ||
static unsigned int getKernelRegisters( | ||
hipFuncAttributes const &hip_func_attributes) { | ||
return hip_func_attributes.numRegs; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing
adding error checking to hipFuncGetAttributes
Cool! Is this something that could also be used within the RAJA Teams framework? |
No description provided.