Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're compiling with pedantic, sorry for the noise #1120

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

DavidPoliakoff
Copy link
Contributor

Summary

  • This PR is a bugfix for pedantic compilers
  • It does the following (modify list as needed):
    • removes an extra semicolon

Let me know if this is problematic, sorry for the noise

@ajpowelsnl
Copy link

ajpowelsnl commented Sep 20, 2021

@DavidPoliakoff , @trws and @rhornung67 -- Quick question: can I pull in all of the changes to fix compiler warnings in RAJA from the "develop" branch?

@trws
Copy link
Member

trws commented Sep 20, 2021

Once this merges, this would get you the raja one and you'd probably need to update to the new camp version, not sure if we've pulled that here yet.

@ajpowelsnl
Copy link

Once this merges, this would get you the raja one and you'd probably need to update to the new camp version, not sure if we've pulled that here yet.

Morning @trws and @DavidPoliakoff -- Tom, many thanks for the update. I am seeing compiler warnings from both RAJA and camp. Would it be possible for you to also address compiler warnings from RAJA dependencies , as well? I am grateful for your help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants