Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StructuralMechanicsApplication] Using AtomicAdd in BaseSolidElement #12180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

loumalouomega
Copy link
Member

📝 Description

Using AtomicAdd in BaseSolidElement. Also adding some missing documentation and some minor clean up.

🆕 Changelog

@loumalouomega loumalouomega added Cleanup Applications Documentation Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Mar 13, 2024
@loumalouomega
Copy link
Member Author

Ups @AlejandroCornejo I wanted to modief the structural elements and I ended modiying yours :P

@loumalouomega loumalouomega requested a review from a team as a code owner March 14, 2024 14:07
// KRATOS_CHECK_VARIABLE_IN_NODAL_DATA(VELOCITY,r_node)
// KRATOS_CHECK_VARIABLE_IN_NODAL_DATA(ACCELERATION,r_node)

KRATOS_CHECK_DOF_IN_NODE(DISPLACEMENT_X, r_node)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the notation

* @return The Rayleigh alpha parameter.
*/
double GetRayleighAlpha(
const Properties& rProperties,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to change the elements from the FemToDemApp?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By error :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Cleanup Documentation FastPR This Pr is simple and / or has been already tested and the revision should be fast Parallel-SMP Shared memory parallelism with OpenMP or C++ Threads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants