Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error should give path to the file #336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Error should give path to the file #336

wants to merge 2 commits into from

Conversation

alexwaeseperlman
Copy link

I've been using this change for debugging and I think it should come with the library.

@coveralls
Copy link

coveralls commented Aug 27, 2019 •
edited

Pull Request Test Coverage Report for Build 208

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 95.556%
Totals Coverage Status
Change from base Build 203: -0.1%
Covered Lines: 705
Relevant Lines: 722
💛 - Coveralls

@jeremyrajan
Copy link
Collaborator

@squishybanana04 thanks for the PR. I feel that would help as well. Maybe add some test cases to include that?

@Keyang thoughts?

@Keyang
Copy link
Owner

Keyang commented Apr 8, 2020

@jeremyrajan Sounds good to me.

@jeremyrajan
Copy link
Collaborator

cool! :)! @squishybanana04 will wait you to add tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexwaeseperlman @coveralls @jeremyrajan @Keyang