UI Updates to Tap Detail View #124
Conversation
…ption to enable/disable
…Done button from being cut off
| <CheckBoxPreference | ||
| android:title="Show ABV when zero" | ||
| android:key="config:ABV_DISPLAY_WHEN_ZERO" | ||
| android:summaryOn="ABV will be displayed even when zero" | ||
| android:summaryOff="ABV will not be displayed when zero" | ||
| android:defaultValue="false"> | ||
| </CheckBoxPreference> | ||
| <CheckBoxPreference | ||
| android:title="Show IBU when zero" | ||
| android:key="config:IBU_DISPLAY_WHEN_ZERO" | ||
| android:summaryOn="IBU will be displayed even when zero" | ||
| android:summaryOff="IBU will not be displayed when zero" | ||
| android:defaultValue="false"> | ||
| </CheckBoxPreference> | ||
| <CheckBoxPreference | ||
| android:title="Show Tap Notes" | ||
| android:key="config:DISPLAY_TAP_NOTES" | ||
| android:summaryOn="Tap Notes will be displayed if available" | ||
| android:summaryOff="Tap Notes will not be displayed" | ||
| android:defaultValue="true"> | ||
| </CheckBoxPreference> |
There was a problem hiding this comment.
This should probably be in the User Interface section of settings_kegerator.xml
There was a problem hiding this comment.
Hmm, yeah I could see it making more sense on that page since that grouping (currently only one item) controls the tap detail display. Makes sense under the title of "Look and Feel", but maybe that should just be "Units" and the UI settings are under Kegerator > User Interface
| <item name="android:layout_height">wrap_content</item> | ||
| <item name="android:ellipsize">end</item> | ||
| <item name="android:singleLine">true</item> | ||
| <item name="android:textSize">22sp</item> |
There was a problem hiding this comment.
Was a touch too big for the default font sizes on my nexus 7. ABV and IBU lines bled together. 20sp looked better to me.
There was a problem hiding this comment.
Sounds good, should also look fine on my 10" tablet and will give just a bit extra room for Beer Name/Tap Name. Definitely tricky trying to get a solution that works on all screen sizes. I need to refresh my memory on the units 'sp'/'dip'. Maybe there's a better way ensure consistent UI.
There was a problem hiding this comment.
sp is supposed to be the better way at least according to what android studio just told me. :)
| // Find ABV and IBU values | ||
| final String abv = String.valueOf(keg.getBeverage().getAbvPercent()); | ||
| if(mCore.getConfiguration().getAbvVisibleWhenZero()) { | ||
| abvText.setText("ABV: " + abv + "%"); |
There was a problem hiding this comment.
I'd personally prefer it to read more naturally, like 6.7% ABV
There was a problem hiding this comment.
I could agree with that, thoughts on also flipping the IBU display? I think having both labels as a prefix or suffix would look best vs. having one as 6.7% ABV and the other IBU: 50. EDIT: Missed the comment below!
| if(mCore.getConfiguration().getAbvVisibleWhenZero()) { | ||
| abvText.setText("ABV: " + abv + "%"); | ||
| } else{ | ||
| abvText.setText(keg.getBeverage().getAbvPercent() == 0 ? "" : "ABV: " + abv + "%"); |
There was a problem hiding this comment.
This should probably just set the visibility to GONE. abvText.setVisibility(View.GONE);
| if(mCore.getConfiguration().getIbuVisibleWhenZero()){ | ||
| ibuText.setText("IBU: " + ibu); | ||
| } else{ | ||
| ibuText.setText(keg.getBeverage().getIbu() == 0 ? "" : "IBU: " + ibu); |
There was a problem hiding this comment.
This should probably just set the visibility to GONE. ibuText.setVisibility(View.GONE);
|
|
||
| final String ibu = String.valueOf(Math.round(keg.getBeverage().getIbu())); | ||
| if(mCore.getConfiguration().getIbuVisibleWhenZero()){ | ||
| ibuText.setText("IBU: " + ibu); |
There was a problem hiding this comment.
I'd personally prefer it to read more naturally, like 17 IBUs
| android:layout_height="wrap_content" | ||
| android:layout_below="@+id/tapStatsBadges" | ||
| android:layout_centerHorizontal="true" | ||
| android:layout_margin="16dp" |
There was a problem hiding this comment.
This feels like a huge margin.
| android:layout_centerHorizontal="true" | ||
| android:layout_margin="16dp" | ||
| android:layout_marginTop="2dip" | ||
| android:padding="16dp" |
There was a problem hiding this comment.
Looked ok on my tablet...but looks better with it eliminated/reduced! Fixed!
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| <!-- Right box: Camera Preview & Controls --> | |||
|
|
|||
| <LinearLayout | |||
| <RelativeLayout | |||
There was a problem hiding this comment.
This change hide the Done Pouring button.
There was a problem hiding this comment.
Aligned camera view to bottom but reverted changes to Done Button/Image/Shout text to maintain visibility on smaller tablet screens.
|
just let me if/when this is ready to go, gents! |
…on smaller tablet screens
|
hey gents! just checking in here, does this still need work? - take your time if so, just making sure you're not waiting on me. |
Here are some updates I made a while ago to add some additional information (ABV/IBU) to the main tap display, as well as clean up some text spacing issues I was experiencing on my Acer A210.
There are a couple things going on with that tablet, mainly that the Android system text size defaults to "Large" which throws things off. Setting to "Normal" looks better but I still adjusted the size so that values are still readable but don't overflow their containers.
Would love to have some additional testing and review on newer devices, almost certainly with higher resolutions.