Fixes #37476 - update ak results in hostgroup #10998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't really speak to what goes on in the code, but it seems to resolve the issue |
jeremylenz
reviewed
May 16, 2024
| @@ -23,24 +23,26 @@ import { selectAPIStatus } from 'foremanReact/redux/API/APISelectors'; | |||
| const ActivationKeysSearch = () => { | |||
| const ACTIVATION_KEYS = 'ACTIVATION_KEYS'; | |||
| const KT_AK_LABEL = 'kt_activation_keys'; | |||
| const selectedEnvId = useMemo(() => { | |||
| const getSelectedEnvId = () => { | |||
There was a problem hiding this comment.
This seems to be vanilla JS, can we move it outside the component so the function isn't recreated on each render? That may provide the same benefit that the useMemo was supposed to.
There was a problem hiding this comment.
yeah, thats a better place for it
jeremylenz
reviewed
May 17, 2024
| return dataId; | ||
| }, []); | ||
| const [selectedEnvId, setSelectedEnvId] = useState(getSelectedEnvId()); | ||
| const [selectedContentViewId, setSelectedContentViewId] = useState(getSelectedContentViewId); |
There was a problem hiding this comment.
Suggested change
| const [selectedContentViewId, setSelectedContentViewId] = useState(getSelectedContentViewId); | |
| const [selectedContentViewId, setSelectedContentViewId] = useState(getSelectedContentViewId()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selecting lifecycle env does not update the ak results in new host group, since useMemo doesnt update.
placeholder prop was wrong and should be placeholderText to show empty results