This repository has been archived by the owner on Apr 4, 2019. It is now read-only.
Fixes #19955 - Various dependencies have vulnerabilities #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:minimatch:20160620 - https://snyk.io/vuln/npm:minimatch:20160620 - https://snyk.io/vuln/npm:tar:20151103 - https://snyk.io/vuln/npm:minimatch:20160620 - https://snyk.io/vuln/npm:semver:20150403 - https://snyk.io/vuln/npm:qs:20140806 - https://snyk.io/vuln/npm:qs:20140806-1 - https://snyk.io/vuln/npm:minimatch:20160620 The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/npm:hawk:20160119 - https://snyk.io/vuln/npm:minimatch:20160620 - https://snyk.io/vuln/npm:ms:20170412 - https://snyk.io/vuln/npm:qs:20140806-1 - https://snyk.io/vuln/npm:request:20160119 - https://snyk.io/vuln/npm:semver:20150403 - https://snyk.io/vuln/npm:tar:20151103 - https://snyk.io/vuln/npm:uglify-js:20151024 Latest report for dlobatog/bastion: https://snyk.io/test/github/dlobatog/bastion Some vulnerabilities weren't fixed or ignored, and so will still fail the Snyk test report.
|
Looks fine as long as testing passes especially since these are all development dependencies. @waldenraines if you don't mind double checking me |
|
We would also want to test all of the various grunt scripts we have. @dLobatog do we want to do a similar check against the user facing dependencies we include via bower.json (and then unfortunately check in)? |
|
[test] |
waldenraines
approved these changes
Oct 19, 2017
There was a problem hiding this comment.
Thanks for this @dLobatog and sorry for the delay in getting this tested and merged.
|
[test] |
2 similar comments
|
[test] |
|
[test] |
|
I am not sure how to get the |
|
[test bastion] |
|
@dLobatog the bastion test failure may require a PR update |
|
[test bastion] |
|
failure is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following vulnerabilities are fixed with an upgrade:
The following vulnerabilities are fixed with a Snyk patch:
Latest report for dlobatog/bastion:
https://snyk.io/test/github/dlobatog/bastion
Some vulnerabilities weren't fixed or ignored, and so will still fail
the Snyk test report.