Polar chart (in progress)

[Qwerty71]

.addSeries and .addFunction work, only issue is when I tried to implement the draw_empty_circle function in the renderers.

[Qwerty71]

Hey, could anyone help me with this issue? How do I clip the graph so that any extraneous lines/circles do not appear? An example of this issue can be found here. Help would be much appreciated!

[WilliamHYZhang]

@Qwerty71 you could include a check to only graph the circles that fall INSIDE the graph perhaps.

[WilliamHYZhang]

Clipping the circles will take significantly more work: you'll have to split them up and graph individual arcs, or maybe include an overlay outside the graph which isn't ideal.

[KarthikRIyer]

@Qwerty71 could you check the allow edits from maintainer option in your PR. I'll fix the build fail by adding the code for QuartzRenderer.
Also I agree with @WilliamHYZhang. Instead of clipping the circles just calculate the maximum radius of the circle that can come in your figure.

[Qwerty71]

Yes. The only problem is that the figure is rectangular, rather than a square, which means that his implementation would fail to cover the external radii. I had the idea of fixing the graph to become a square (have the axes be the same for both), and then I can get it to work. If you have any suggestions in implementing that, please let me know :)

…

On Fri, Jan 24, 2020, 1:01 PM Karthik Ramesh Iyer ***@***.***> wrote: @Qwerty71 <https://github.com/Qwerty71> could you check the allow edits from maintainer option in your PR. I'll fix the build fail by adding the code for QuartzRenderer. Also I agree with @WilliamHYZhang <https://github.com/WilliamHYZhang>. Instead of clipping the circles just calculate the maximum radius of the circle that can come in your figure. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#106?email_source=notifications&email_token=AH4TA2G7X6JKDWGFUJ6KWF3Q7MUI5A5CNFSM4KKRMOX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3TAHA#issuecomment-578236444>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH4TA2CWTARQMVNZJW5GZG3Q7MUI5ANCNFSM4KKRMOXQ> .

[KarthikRIyer]

Actually you'd have to re-implement the plot instead of reusing Line Graph code. Try taking a look at the line graph code to understand the flow. Let me know if you have any doubts. Then we can move on to implementing this plot from scratch.

Line graph takes in width and height. You can instead have just one parameter for Polar Chart.

[KarthikRIyer]

Also we do not want the rectangle border. The border should be circular. Take a look at how matplotlib polar plot results look like. https://matplotlib.org/gallery/misc/transoffset.html#sphx-glr-gallery-misc-transoffset-py

[Qwerty71]

Got it. I can implement the arc function, but if we want to make the borders circular then there is no need. In fact, if we make the borders circular, then there is no need for a background layout at all - all I need to do is draw the circles. Would you like me to include the degree measure in the plot?

[KarthikRIyer]

Yes, it'd be nice to include the degree measure. Try to replicate the example I sent above, as much as possible.

[Qwerty71]

Sorry, I've been rather busy lately. I will finish this task and implement Polar Plot when I can. So far, I need to
a) make the grids circles (and the border, as per matplotlib style)
b) add degree measures
c) (if necessary - it would be convenient but is no longer needed) create function to generate arcs.

[KarthikRIyer]

No worries @Qwerty71. This isn't an urgent task. Take your time. :D

[WilliamHYZhang]

Nice to see progress on this! Keep it up 👍