Manga reader fixes #2942
Closed
Manga reader fixes #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fixed - Fixed: Fixed an issue where one some screens images would stack instead of being side by side while using the double setting in the manga reader.
Fixes #2891
therobbiedavis
changed the title
therobbiedavis
changed the title
|
Reported back cutoff issues via discord, but overall this is looking MUCH better aligned to how I think the reader should function. |
"dynamic viewport size allows the content you design to fit exactly within the viewport, irrespective of the presence of dynamic browser interfaces." https://developer.mozilla.org/en-US/docs/Web/CSS/length#dynamic dvh is available for all major browsers: https://caniuse.com/viewport-unit-variants
As requested by Joe
|
This will be taken care of in #1426 as I needed to test 2 different PRs at once. |
|
@majora2007 I think you have the wrong reference, #1426 is over two years old. I think it should be #2960. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Changes
Width (large resolution):
Width (mobile, portrait):
Width (mobile, landscape)
Height (large resolution):
Height (mobile, portrait):
Height (mobile, landscape)
Original (large resolution):
Original (mobile, portrait):
Original (mobile, landscape):
