-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: book reader swipe pagination #2754
base: develop
Are you sure you want to change the base?
feat: book reader swipe pagination #2754
Conversation
…ot clickToPaginate being disabled to toggleMenu
…her distance or speed threshold is passed
I added the toggle for this feature to the user preferences page, but for it to work we need to add the migration. I've done this before, but I can't figure out how it's done in this stack. I'm happy to read documentation and add it myself |
To add the migration you add the setting to the user preferences entity then type Review the SQL and launch Kavita to have it applied. |
Great, I'll also see about adding this to the readme or somewhere so it's documented, I'm sure I'll need to reference it in the future. |
Just an FYI, I am still planning to review this. I have all bugfixes and PRs on hold until I wrap this comic rework. I'm really curious to see how this works and go through the code. |
Hey, just curious if you're up for fixing merge conflicts? I have wrapped the comic rework stuff and there is time to review this and see if it can make the v0.8 release. |
698f16d
to
7937dd2
Compare
…ginate is enabled.
…abling tap pagination
7937dd2
to
2d70a29
Compare
Quality Gate passedIssues Measures |
…eature/book-reader-swipe-pagination
Sorry it took a while, but the merge conflicts have been resolved, and I tried to clean up the commit history |
Thanks, I'll review the PR this week. Looks like quite a big one. |
Added
Changed
Fixed
TODO