Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple remote versions #3036

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blowfishpro
Copy link

This will be used by AVC to determine the newest version for your KSP version. For NetKAN's purpose we just need the matching version.

Dealing with remote version info replacing local
If the root element is an array, look for exactly one matching version

This will be used by AVC to determine the newest version for your KSP version.  For NetKAN's purpose we just need the matching version.
@blowfishpro
Copy link
Author

blowfishpro commented Apr 17, 2020

AVC equivalent (needs to be rebased): linuxgurugamer/KSPAddonVersionChecker#35

@HebaruSan
Copy link
Member

Pretty cool! Thanks for the PR.
Some suggestions submitted in blowfishpro#1.

@HebaruSan
Copy link
Member

We'll probably need an update for KSP-AVC krefs as well in case ExtraplanetaryLaunchpads, EarlyBird, or CustomBulkheadProfiles decides to take advantage of this, see #2517.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Netkan Issues affecting the netkan data Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants