Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force delete generic system links #565

Merged
merged 9 commits into from
Feb 18, 2024

Conversation

chrismarget-j
Copy link
Collaborator

@chrismarget-j chrismarget-j commented Feb 18, 2024

This PR adds a new attribute clear_cts_on_destroy to the apstra_datacenter_generic_system resource (customer request)

When true, if we find that the generic system (or one of its links) cannot be deleted (SDK #217) either in Delete() or Update(), we attempt to clear the offending CTs and then try again to delete the links in question.

The tests were an adventure because we need to do some intervention (attach a CT) between steps executed by the acceptance testing framework.

I pushed the t.Helper() philosophy forward a bit as well.

@chrismarget-j chrismarget-j changed the title WIP: Force delete generic system links Force delete generic system links Feb 18, 2024
@rajagopalans
Copy link
Collaborator

I notice that the branch names are becoming descriptive. This is the process we used to follow earlier. I thought we were going to move to feat/ or bug/ , as documented in the Contribute section of the README.
I don't have a strong feeling one way or the other FWIW.

@chrismarget-j
Copy link
Collaborator Author

chrismarget-j commented Feb 18, 2024

I didn't remember opening an issue for this topic, but it seems I did.

This branch should have been feat/553-force-delete-generic-system-links (optional descriptive text)

Closes #553

@chrismarget-j chrismarget-j merged commit a29d0d8 into main Feb 18, 2024
1 check passed
@chrismarget-j chrismarget-j deleted the force-delete-generic-system-links branch February 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants