add 'member' to reboot RPC only when it's not None #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parentheses were missing to reflect the right logic
lib/jnpr/junos/utils/sw.py
Outdated
| @@ -1131,8 +1131,8 @@ def _system_operation( | |||
| elif self._mixed_VC is True: | |||
| cmd.append(E("all-members")) | |||
| elif ( | |||
| self._multi_VC_nsync is True | |||
| or self._multi_VC is True | |||
| (self._multi_VC_nsync is True | |||
There was a problem hiding this comment.
Kindly fix the format for your fix by running "black" tools. Workflow is failing with your fix
There was a problem hiding this comment.
Ok, format is now updated according to 'black'.
dineshbaburam91
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic adds the 'member' attribute to the request-reboot RPC, even if the member attribute is 'None' (default) while the target device is running on a single-node virtual chassis.
This causes the RPC call to fail.
-> parentheses were missing to reflect the right logic