Closes-Bug: #1569823 -- Look and feel improvement for port page

Fixed the heading alignment of DHCP options and Bindings in the Port Detail Change-Id: I7a0e508aa63f4d5ed8a5c932aa3eaea9bc8d7d6f
Juniper · May 13, 2016 · 69f846a · 69f846a
1 parent 65e6c76
commit 69f846a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/webroot/config/networking/port/ui/js/views/portFormatters.js b/webroot/config/networking/port/ui/js/views/portFormatters.js
@@ -216,13 +216,15 @@ define([
                            "");
             if(dhcpVals != "" && dhcpVals.length > 0){
                 var dhcp_length = dhcpVals.length;
-                dhcp = "<table><tbody><tr><td>Code</td><td>Value</td></tr>"
+                dhcp = "<table width='100%'><thead><tr><th class='span4'>Code</th><th class='span4'>Value</th><th class='span4'>Value in Bytes</th></tr></thead><tbody>"
                 for(var i = 0; i < dhcp_length;i++) {
                     var dhcpVal = dhcpVals[i];
                     dhcp += "<tr><td>";
                     dhcp += dhcpVal["dhcp_option_name"]
                     dhcp += "</td><td>";
-                    dhcp += dhcpVal["dhcp_option_value"]
+                    dhcp += dhcpVal["dhcp_option_value"] ? dhcpVal["dhcp_option_value"] : "-";
+                    dhcp += "</td><td>";
+                    dhcp += dhcpVal["dhcp_option_value_bytes"] ? dhcpVal["dhcp_option_value_bytes"] : "-" ;                   
                     dhcp += "</td></tr>";
                 }
                 dhcp += "</tbody></table>";
@@ -341,10 +343,10 @@ define([
                           []);
             if(portBindingData.length > 0) {
                 var portBinding_length = portBindingData.length;
-                portBinding = "<table><tbody><tr><td>Key</td><td>Value</td></tr>"
+                portBinding = "<table width='100%'><thead><tr><th class='span5'>Key</th><th class='span7'>Value</th></tr></thead>"
                 for(var i = 0; i < portBinding_length;i++) {
                     var portBindingVal = portBindingData[i];
-                    portBinding += "<tr><td>";
+                    portBinding += "<tbody><tr><td>";
                     if(portBindingVal["key"] == "vnic_type" &&
                        portBindingVal['value'] == "direct") {
                         portBinding += "SR-IOV (vnic_type:direct)";