Skip to content

Commit

Permalink
Disable vlan offload as it causes performance degradation.
Browse files Browse the repository at this point in the history
Change-Id: Id7bd20a040a1aa3c1ad4b1c6f68c10a9836d6108
Closes-Bug: 1641254
  • Loading branch information
srajag committed Nov 14, 2016
1 parent e8e263d commit cbbe4d4
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions dpdk/vr_dpdk_interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,6 @@ dpdk_set_addr_vlan_filter_strip(uint32_t port_id, struct vr_interface *vif)
{
if (vif->vif_flags & VIF_FLAG_VLAN_OFFLOAD) {
rte_eth_dev_set_vlan_strip_on_queue(*port_id_ptr, i, 1);
} else {
rte_eth_dev_set_vlan_strip_on_queue(*port_id_ptr, i, 0);
}
}
port_num++;
Expand Down Expand Up @@ -251,7 +249,10 @@ dpdk_vif_attach_ethdev(struct vr_interface *vif,

if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_VLAN_INSERT
&& dev_info.rx_offload_capa & DEV_RX_OFFLOAD_VLAN_STRIP) {
vif->vif_flags |= VIF_FLAG_VLAN_OFFLOAD;
/*
* Enabling vlan offload causes performance degradation, possibly
* dut to a DPDK library issue, so don't set VIF_FLAG_VLAN_OFFLOAD
*/
} else {
vif->vif_flags &= ~VIF_FLAG_VLAN_OFFLOAD;
}
Expand Down

0 comments on commit cbbe4d4

Please sign in to comment.