Merge "Fix memory corruption at the time of unloading"

Juniper · Mar 28, 2016 · 27904db · 27904db
2 parents 1c87b2b + 2cef39d
commit 27904db
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/dp-core/vr_stats.c b/dp-core/vr_stats.c
@@ -331,6 +331,7 @@ vr_malloc_stats_exit(struct vrouter *router)
     }
 
     vr_free(router->vr_malloc_stats, VR_MALLOC_OBJECT);
+    router->vr_malloc_stats = NULL;
 
     return;
 }
@@ -451,8 +452,8 @@ vr_stats_exit(struct vrouter *router, bool soft_reset)
         return;
     }
 
-    vr_malloc_stats_exit(router);
     vr_pkt_drop_stats_exit(router);
+    vr_malloc_stats_exit(router);
     return;
 }
 

diff --git a/linux/vhost_dev.c b/linux/vhost_dev.c
@@ -494,7 +494,7 @@ vhost_dellink(struct net_device *dev, struct list_head *head)
 
     vp = netdev_priv(dev);
     if (vp) {
-        if (vp->vp_db_index >= 0)
+        if (vhost_priv_db && vp->vp_db_index >= 0)
             vhost_priv_db[vp->vp_db_index] = NULL;
 
         vp->vp_db_index = -1;
@@ -566,8 +566,10 @@ void
 vhost_exit(void)
 {
     vhost_netlink_exit();
-    if (vhost_priv_db)
+    if (vhost_priv_db) {
         kfree(vhost_priv_db);
+        vhost_priv_db = NULL;
+    }
 
     return;
 }

diff --git a/linux/vr_host_interface.c b/linux/vr_host_interface.c
@@ -2334,8 +2334,8 @@ vr_host_vif_init(struct vrouter *router)
 void
 vr_host_interface_exit(void)
 {
-    vhost_exit();
     unregister_netdevice_notifier(&host_if_nb);
+    vhost_exit();
     linux_pkt_dev_free();
 
 #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,39))